Check Run Annotations #1864
Check Run Annotations #1864
Conversation
|
@donokuda... send 💕 |
…tions # Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
StanleyGoldman
force-pushed
the
features/check-suite-annotations
branch
from
c7ba7d6 to
95d0079
Compare
…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
StanleyGoldman
changed the title
…hub.com/github/VisualStudio into features/check-suite-annotations-inline
Update inline review / annotation margin glyph
…eck-suite-annotations
…uite-annotations-inline
…-inline-available-for-comment Check Run Annotations should be able to disable the Add Comment functionality
…uite-annotations-inline
…-inline Check Run Annotations Inline
| public DateTimeOffset? CompletedAt { get; set; } | ||
|
|
||
| /// <summary>The name of the check for this check run.</summary> | ||
| /// <summary> |
|
Couple of things I've noticed with the commenting behavior after this PR:
|
…/github/VisualStudio into features/check-suite-annotations
This might help with visually grouping comment threads in the future
This was intended. I was exploring different ways of indicating if a line had an annotation, a comment, both, and what kind of annotation. Here's a crop of a work-in-progress mockup:
The challenge I ran into was how to represent more than one annotation marker in the margin and decided on one to show to simplify things. However, I'll work on iterating in @StanleyGoldman's pull request for using different markers. |
|
Heads up, I pushed a change that removed some border lines between comments. My (future) intent is to group comment threads together and removing borders will make this easier visibly.
|
|
Ok, thanks for the details @donokuda - I've merged this, lets iterate on it in separate PRs. Those mockups look great! |
This pull request adds functionality to:
Remaining
Before merging
Images